feat(php): undiscriminated unions #4783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amckinney
approved these changes
Oct 1, 2024
| return attributes; | ||
| } | ||
|
|
||
| public getArrayTypeAttributeArgument(type: php.Type): php.AstNode { | ||
| public getUnionTypeClassRepresentation(arguments_: php.AstNode[]): ClassInstantiation { |
There was a problem hiding this comment.
nit:
Suggested change
| public getUnionTypeClassRepresentation(arguments_: php.AstNode[]): ClassInstantiation { | |
| public getUnionTypeClassInstantiation(arguments_: php.AstNode[]): ClassInstantiation { |
Ideally the argument could be a little more strongly typed (e.g. php.Type). Otherwise it's possible to write in arbitrary php.CodeBlock here. But I know it's difficult because of the getTypeAttributeArgument helper function below - the attributes aren't the same as the type representation (e.g. int vs integer).
Fine with this for now, but we'll need to be careful to call this with arguments that make sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces support in PHP for undiscriminated unions, including the following: